feat: 'move' cursor added over brush mark #9164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-lite into touch-to-pointer-events
…(interpolatedSignalRef) (vega#9111) Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Bumps [jest-dev-server](https://github.com/argos-ci/jest-puppeteer/tree/HEAD/packages/jest-dev-server) from 9.0.0 to 9.0.1. - [Release notes](https://github.com/argos-ci/jest-puppeteer/releases) - [Changelog](https://github.com/argos-ci/jest-puppeteer/blob/main/packages/jest-dev-server/CHANGELOG.md) - [Commits](https://github.com/argos-ci/jest-puppeteer/commits/v9.0.1/packages/jest-dev-server) --- updated-dependencies: - dependency-name: jest-dev-server dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.22.20 to 7.23.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.0/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [terser](https://github.com/terser/terser) from 5.19.4 to 5.20.0. - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](terser/terser@v5.19.4...v5.20.0) --- updated-dependencies: - dependency-name: terser dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
alliefeldman
force-pushed
the
brush-cursor
branch
from
829bf87
to
a667fbb
Compare
alliefeldman
force-pushed
the
brush-cursor
branch
from
a8c777b
to
1340766
Compare
alliefeldman
force-pushed
the
brush-cursor
branch
from
b66ce59
to
bbf1cd4
Compare
alliefeldman
force-pushed
the
brush-cursor
branch
from
6f205de
to
1c9b06b
Compare
domoritz
requested changes
Nov 3, 2023
| @@ -259,7 +259,7 @@ | |||
| "clip": true, | |||
| "encode": { | |||
| "enter": { | |||
| "cursor": {"value": "pointer"}, | |||
There was a problem hiding this comment.
Why is this one changing? Seems odd that there was one already and you override it.
| @@ -794,7 +794,7 @@ describe('Interval Selections', () => { | |||
| type: 'rect', | |||
| clip: true, | |||
| encode: { | |||
| enter: {fill: {value: 'transparent'}}, | |||
| enter: {cursor: {value: 'move'}, fill: {value: 'transparent'}}, | |||
There was a problem hiding this comment.
Add tests that check that we don't add a cursor when
- it's already defined
- or the selection cannot be moved (iirc Arvind made a commend about that somewhere but I can't find it right now)
|
I'm the future, please update an existing pull request/branch rather than opening a new one so we preserve comments better. |
|
Converting to draft for now. Please mark as ready when it's ready. |
|
thank you @alliefeldman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To create affordance for brush panning, switch the user's mouse cursor to 'move' when dragging/hovering over a displayed interval selection.
Contributes to #4155