Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make tick support relative band size (so it works better with binned fields) #9176

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

fix: make tick support relative band size (so it works better with binned fields) #9176

wants to merge 17 commits into from

Commits on Nov 15, 2023

  1. docs(example): add tick on binned axis examples (which doesn't work yet)

    @kanitw
    kanitw committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7303fb0 View commit details
    Browse the repository at this point in the history

  2. chore: update examples [CI]

    GitHub Actions Bot committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e71751e View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. fix: better adapt tick width dimension with binned fields 

    (by sharing the code for tick's dimension axis with rectangle/bar)

Also convert `RectBinSpacingMixins` into `BandSizeConfigMixins`
    @kanitw
    kanitw committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    7b999db View commit details
    Browse the repository at this point in the history

  2. chore: update schema [CI]

    GitHub Actions Bot committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    fcfb551 View commit details
    Browse the repository at this point in the history

  3. chore: update examples [CI]

    GitHub Actions Bot committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    090e41d View commit details
    Browse the repository at this point in the history

  4. docs(examples): add broken example for #9177

    @kanitw
    kanitw committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b4d0566 View commit details
    Browse the repository at this point in the history

  5. chore: update examples [CI]

    GitHub Actions Bot committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    efacdd0 View commit details
    Browse the repository at this point in the history

  6. fix: apply bandPosition to offset channel for grouped bar (so band si… 

    …ze works with grouped bars)

fix #9177
    @kanitw
    kanitw committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0d7ec05 View commit details
    Browse the repository at this point in the history

  7. chore: update examples [CI]

    GitHub Actions Bot committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    4deb363 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'kw/9177-grouped-bar-discrete-bandSize' into kw/tick-bar

    @kanitw
    kanitw committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    df8602e View commit details
    Browse the repository at this point in the history

  9. docs(examples): add examples (relative band size for width works, but… 

    … not for size)
    @kanitw
    kanitw committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    24b75eb View commit details
    Browse the repository at this point in the history

  10. chore: update examples [CI]

    @kanitw
    GitHub Actions Bot authored and kanitw committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    7547ba5 View commit details
    Browse the repository at this point in the history

  11. fix(#9173): make mark.size support relative band size (e.g., {"band":… 

    … 0.5}) for bars and ticks
    @kanitw
    kanitw committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b2b2a76 View commit details
    Browse the repository at this point in the history

  12. chore: update examples [CI]

    GitHub Actions Bot committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    2aeffca View commit details
    Browse the repository at this point in the history

  13. Merge branch 'kw/9173-relative-band-size' into kw/tick-bar

    @kanitw
    kanitw committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0952a67 View commit details
    Browse the repository at this point in the history

  14. chore: update schema [CI]

    GitHub Actions Bot committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    88b1a19 View commit details
    Browse the repository at this point in the history

  15. chore: update examples [CI]

    GitHub Actions Bot committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    715ffb3 View commit details
    Browse the repository at this point in the history