Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update ecosystem.md on Java binding in Smile #9302

Merged
merged 2 commits into from
Apr 3, 2024
Merged

docs: update ecosystem.md on Java binding in Smile #9302

merged 2 commits into from
Apr 3, 2024

Conversation

haifengl
Copy link
Contributor

@haifengl haifengl commented Apr 3, 2024 •
edited

PR Description

Checklist

  • This PR is atomic (i.e., it fixes one issue at a time).
  • The title is a concise semantic commit message (e.g. "fix: correctly handle undefined properties").
  • yarn test runs successfully
  • For new features:
    • Has unit tests.
    • Has documentation under site/docs/ + examples.

Tips:

domoritz
domoritz approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docs: to the title

site/ecosystem.md Outdated Show resolved Hide resolved
@haifengl haifengl changed the title Update ecosystem.md on Java binding in Smile docs: update ecosystem.md on Java binding in Smile Apr 3, 2024
@haifengl
Copy link
Contributor Author

haifengl commented Apr 3, 2024

Please add docs: to the title

Done. Thanks for approval.

@domoritz domoritz merged commit 6086090 into vega:master Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haifengl @domoritz