Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for filtering & sorting values #820

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: add support for filtering & sorting values #820

wants to merge 5 commits into from

Conversation

sfc-gh-cheliu
Copy link

@sfc-gh-cheliu sfc-gh-cheliu commented Sep 27, 2023 •
edited by domoritz

Closes vega/vega-lite#9152

This requires to modify vega-lite as well: vega/vega-lite#9148

cc: @joelostblom @jakevdp @kanitw @domoritz @arvind @jheer

This was referenced Sep 27, 2023
Closed
Open
@sfc-gh-cheliu sfc-gh-cheliu changed the title Test filtering zeros and sort values in tooltip. Test filtering zeros and sorting values in tooltip. Oct 4, 2023
@sfc-gh-cheliu
Copy link
Author

@domoritz @joelostblom @jakevdp @kanitw @arvind @jheer Could someone take a look at this? Thanks!

@sfc-gh-cheliu sfc-gh-cheliu mentioned this pull request Oct 10, 2023
Open
@domoritz domoritz self-assigned this Oct 10, 2023
@sfc-gh-cheliu sfc-gh-cheliu mentioned this pull request Oct 17, 2023
Open
@sfc-gh-cheliu sfc-gh-cheliu changed the title Test filtering zeros and sorting values in tooltip. Add support for filtering & sorting values in vega-tooltip. Oct 22, 2023
This was referenced Oct 22, 2023
Closed
Draft
@domoritz domoritz changed the title Add support for filtering & sorting values in vega-tooltip. feat: add support for filtering & sorting values Oct 23, 2023
@domoritz
Copy link
Member

I wonder whether we need any changes in Vega tooltip. Sorting and filtering could be done entirely in Vega I think.

Moving discussion to vega/vega-lite#9152 and putting pull request on hold for now.

@domoritz domoritz marked this pull request as draft October 23, 2023 01:02
@sfc-gh-cheliu sfc-gh-cheliu mentioned this pull request Oct 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@domoritz domoritz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering out zero/null values in tooltip and sort the tooltip by field values
2 participants
@sfc-gh-cheliu @domoritz