Optimize selection functions for ID-only stores #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvind
force-pushed
the
as/selectionIdFunctions
branch
from
e945b6a
to
a754122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With geo-interval (vega/vega-lite#6953) and lasso (vega/vega-lite#7932, #3388) selections on the horizon, there are going to be not only many more ID-driven selections than before, but these selections are likely going to capture many more IDs than before.
In #3009, we began the process of adding more optimized functions for inclusion testing ID-driven selections. This PR completes that journey by adding code paths that produce terser selection ID tuples and resolves them in a terser fashion as these tuples are stored in a sorted order.