Support remote images #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As always, your speed is impressive! Great solution to the problem and glad to know that I can continue with implementing basemaps based on remote tile images knowing that vl-convert can now support this approach. |
Interested to hear more about this at some point! |
|
Still early stages but I just published a first draft at https://github.com/binste/altair_basemap. The repo might be moved to the altair-viz org or the feature directly implemented in Vega-Lite, see vega/vega-lite#8885, not sure yet. You can see some examples in this notebook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
Implements a custom usvg image string resolver that uses the reqwest crate to download remote image files to temporary files so that usvg will pick them up properly.
cc @binste