Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config bug where mockery crashes when package map is nil #730

Merged
merged 7 commits into from Nov 6, 2023

Commits on Nov 5, 2023

  1. Fix config bug where mockery crashes when package map is nil

    Fixes issue vektra#726.
    
    We needed an additional bit of logic to ensure that if the `config` section
    is nil that we default it to being an empty map.
    LandonTClipp committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    77064ad View commit details
    Browse the repository at this point in the history
  2. Add fix for showconfig command

    This commit adds a fix where we create a copy of the top-level config map, instead
    of using it directly. Previously this situation caused an infinite loop in the
    map structure, so creating a copy prevents that from happening.
    LandonTClipp committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    0310201 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Fix test with config initialization

    The test wasn't properly initializing the viper object so the config
    wasn't getting decoded into the struct properly.
    
    Also adding more comments to various places to better explain what the
    code was doing, as even I, the person who wrote it, was confused as to what
    I was doing. How can I expect other people to understand it if I can't?!
    LandonTClipp committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5978bc5 View commit details
    Browse the repository at this point in the history
  2. Simplifying some config in interface copying code

    fix usage of predeclared identifier
    LandonTClipp committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e86d230 View commit details
    Browse the repository at this point in the history
  3. Fix bug with sub-package inheritance

    Subpackages were not correctly inheriting their parent package
    configuration.
    LandonTClipp committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    d3515d1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2dd8f00 View commit details
    Browse the repository at this point in the history
  5. Add additional test

    LandonTClipp committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    b648c23 View commit details
    Browse the repository at this point in the history