Add support for channels in Samples #98
Open
+63
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Editing the Channel TextBox will enable downgrades
|
Hey, thanks a lot for this! I think I would like to keep the current samples as simple as possible, but I will have a look through this soon and see if I can extract it into a different "channels" sample. |
|
Hey, if you don't mind I'm going to keep this open as I'd still like to incorporate it into a new channels sample ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When evaluating velopack I had to test switching channels so I added the possibility to the samples.
I also updated the build script so the framework parameter matches the documentation.
Are you interested in having the changes? Otherwise, feel free to just close the PR.