Make sort sensitivity opt-in and configurable #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,5 +162,24 @@ describe('SortByKeyPostProcessor', () => { | |||
| i: { value: 'letter i', sourceFiles: [] }, | |||
| j: { value: 'letter j', sourceFiles: [] } | |||
| }); | |||
|
|
|||
| expect(Object.keys(processor.process(collection, new TranslationCollection(), new TranslationCollection()).values)).to.deep.equal( | |||
| Object.keys({ | |||
There was a problem hiding this comment.
I don't understand what this assertion is testing beyond what the test above it is testing? Can you clarify this?
| @@ -110,6 +110,7 @@ Output | |||
| --format, -f Format [string] [choices: "json", "namespaced-json", "pot"] [default: "json"] | |||
| --format-indentation, --fi Format indentation (JSON/Namedspaced JSON) [string] [default: "\t"] | |||
| --sort, -s Sort strings in alphabetical order [boolean] | |||
| --sort-sensitivity, -ss Sensitivity when sorting strings [string] | |||
There was a problem hiding this comment.
I think it would be good to add a dedicated section to the readme about sorting now. If I understand correctly, the -ss flag only has an effect in combination with the -s flag right? That should be noted.
Also this section can explain how strings will be sorted without the -ss flag, as well as what the different options are and what effect they have on the sort order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent PR (#35), the sorting of strings was adjusted to be case-insensitive. This is not an option for us, so I made the functionality optional with the parameter
--sort-sensitivity. If not provided, the old behavior is re-applied.The unit tests for the postprocessor so they have been updated and expanded