Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for extraction of translation keys from function expressions #46

Conversation

pmpak
Copy link

@pmpak pmpak commented May 4, 2024

I tested it in a couple of small / medium sized projects and there was not any issue. However @michaelbromley if you merge this PR it would be better, if possible, to do a pre-release (beta/ next) before proceeding to a stable release to allow for more testing and make sure that these changes won't cause disruption.

Closes #44

@michaelbromley michaelbromley merged commit afa2e69 into vendure-ecommerce:master May 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TranslateService used as an injected const does not work in a const method (like HttpInterceptorFn)
2 participants