Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vercel deploy config and platform specific tweaks #75

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

dmi3y
Copy link

@dmi3y dmi3y commented Mar 8, 2024

  • Add specific Vercel deploy config
  • Use regular dynamic import vs safe import

Assume Vercel does some pre-optimization and if left as safe import it breaks deployment, that likely increases bundle size though. Not sure what could be a better alternative.

related to #67

@dmi3y dmi3y marked this pull request as draft March 8, 2024 22:44
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for inspiring-boba-355f4d ready!

Name Link
🔨 Latest commit 7004bba
🔍 Latest deploy log https://app.netlify.com/sites/inspiring-boba-355f4d/deploys/65fe803888bb0e000846e7d2
😎 Deploy Preview https://deploy-preview-75--inspiring-boba-355f4d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dmi3y dmi3y mentioned this pull request Mar 8, 2024
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for remix-vendure ready!

Name Link
🔨 Latest commit 7004bba
🔍 Latest deploy log https://app.netlify.com/sites/remix-vendure/deploys/65fe80385c8b5800080d69ff
😎 Deploy Preview https://deploy-preview-75--remix-vendure.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dmi3y
Copy link
Author

dmi3y commented Mar 8, 2024

Oh, I see now it's broken on Netlify deploy :(

PS: Though I see same broken deploys on previously merged PR 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant