Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version vendure and fixed bug mac m1 #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lucasvieceli
Copy link

update version vendure and fixed bug mac m1

@michaelbromley
Copy link
Member

Hi @lucasvieceli
Thank you for your contribution!
I have a few points / questions:

  1. Would you be able to do this PR without formatting all the files? It makes it really hard to see the important changes.
  2. You have removed a number of devDependencies which are required during setup like fs-extra and @vendure/create. Why?
  3. Why is the RUN yarn build command commented out in the vendure-docker file?

- modified setup.ts, because when starting the "work" service it reported that it couldn't find the assets folder, in the "server" service it will only create the assets folder templates email. And in the "server" you will populate the tables and the images of the products
- Added fs-extra
@lucasvieceli
Copy link
Author

In this pull request, I created a project on my machine with the new version, and passed it to the docker repository, the folder "src", the file "tsconfig.json" and "migrations.ts"

I made a new commit with some changes

  • Added @vendure/create in package.json
  • Modified setup.ts, because when starting the "work" service it reported that it couldn't find the assets folder, in the "server" service it will only create the assets folder templates email. And in the "server" you will populate the tables and the images of the products
  • Added fs-extra
  • Removed "yarn build", because it is running ts-node directly
  • I will remove spaces as requested

sorry english (google)

@lucasvieceli
Copy link
Author

removed spaces and added .editorconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants