feat(core): Add replicationMode for ctx and getRepository #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thanks, this looks good. Can you make a suggestion for some documentation on this feature? At least as doc blocks on the new method/property. |
Of course, I will. I can do it tomorrow |
monrostar
commented
Apr 3, 2024
| ): Repository<Entity>; | ||
| getRepository<Entity extends ObjectLiteral>( | ||
| ctxOrTarget: RequestContext | ObjectType<Entity> | EntitySchema<Entity> | string | undefined, | ||
| maybeTarget?: ObjectType<Entity> | EntitySchema<Entity> | string, | ||
| replicationMode?: ReplicationMode, |
There was a problem hiding this comment.
Here it's probably better to use an object instead of a strict arg
There was a problem hiding this comment.
For future extensibility?
There was a problem hiding this comment.
yes. For example, there may be several databases in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes improvements for connecting to the database if you are using multiple replicas and when you need to connect to Master without using TransactionManager
Breaking changes