Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Handle async onRetry #50

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

whitecrownclown
Copy link
Contributor

@whitecrownclown whitecrownclown commented Jan 10, 2019

Hello,

This PR is related to #43

I'm not sure about this current implementation, i'd be glad to get someone to review this. (if you don't mind @leo )
A couple of things:

  • Name of the flag, right now it's awaitOnRetry;
  • Should it have different opts object or be documented separately from node-retry opts ?
  • Currently using async await, not sure of the targeted browsers, but i assume promises would be more acceptable, will follow up on this if it's a concern;

Thanks!

@vercel
Copy link

vercel bot commented Jan 10, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@vercel vercel deleted a comment from vercel bot Apr 2, 2019
@christiansaiki
Copy link

christiansaiki commented May 5, 2020

Any chance of getting this merged?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants