Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(primitives): expose AbortController & AbortSignal types properly #109

Merged
merged 1 commit into from Aug 24, 2022

Conversation

feugy
Copy link
Member

@feugy feugy commented Aug 24, 2022

📖 What's in there?

When @Kikobeats released 1.1.0-beta.29 and referenced it in Next.js (vercel/next.js#39898), it failed because of the new AbortSignal types

This PR fixes it

🧪 How to test it?

  1. get your own copy of Next.js locally
  2. in edge-runtime repository:
    pnpm i
    pnpm ln -g
    pnpm build
  3. in next.js repository:
    cd packages/next
    pnpm ln -g edge-runtime @edge-runtime/primitives
    cd ../..
    pnpm --filter next ncc-compiled
    pnpm build

This should complete with no errors.

@feugy feugy requested a review from a team August 24, 2022 13:44
@vercel
Copy link

vercel bot commented Aug 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
edge-runtime ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 1:44PM (UTC)

@Kikobeats Kikobeats changed the title fix(runtime): invalid typings fix(primitives): expose AbortController types properly Aug 24, 2022
@Kikobeats Kikobeats changed the title fix(primitives): expose AbortController types properly fix(primitives): expose AbortController & AbortSignal types properly Aug 24, 2022
@Kikobeats Kikobeats merged commit ac82545 into main Aug 24, 2022
@Kikobeats Kikobeats deleted the fix/runtime-types branch August 24, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants