Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Uint8Array available for TextDecoder #48

Merged
merged 3 commits into from Jul 27, 2022

Conversation

jridgewell
Copy link
Contributor

@jridgewell jridgewell commented Jul 25, 2022

@vercel
Copy link

vercel bot commented Jul 25, 2022

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/concepts/teams/roles-and-permissions

@vercel
Copy link

vercel bot commented Jul 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
edge-runtime ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 1:03PM (UTC)

@Kikobeats Kikobeats changed the title test: add case for TextDecoder inside VM with Uint8Array from parent fix: make Uint8Array available for TextDecoder Jul 27, 2022
This test is never going to work since code will be evaluated inside vm as a whole thing, so comparing with an outside constructor will never be solvable
@Kikobeats Kikobeats merged commit 50bdb9f into vercel:main Jul 27, 2022
@jridgewell jridgewell deleted the textdecoder-bug branch July 27, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextDecoder inside VM with Uint8Array from parent
2 participants