Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency conflict with Next.js package #795

Merged
merged 2 commits into from Feb 6, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 5, 2024

Currently we are unable to publish any Next.js versions that include the jest-environment package in the tree due to a bug in the npmcli that attempts resolving the dependency tree during a publish but fails to handle a circular dependency.

Hoisting the next devDependency to the root should resolve this issue.

x-ref: slack thread

Copy link

changeset-bot bot commented Feb 5, 2024

🦋 Changeset detected

Latest commit: 6b69e15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@edge-runtime/jest-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
edge-runtime ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 9:11am

@ijjk ijjk requested a review from Kikobeats February 5, 2024 19:07
ijjk added a commit to vercel/next.js that referenced this pull request Feb 5, 2024
See here for additional context
vercel/edge-runtime#795 but TLDR is due to a bug
in the `npmcli` we aren't able to publish Next.js releases after this
package was upgraded.

We can re-land the upgrade after that PR is landed/published. 

Reverts #61030

Closes NEXT-2367
@Kikobeats
Copy link
Member

Thanks for taking care @ijjk 🙏

@Kikobeats Kikobeats merged commit c368a54 into main Feb 6, 2024
9 checks passed
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
@Kikobeats Kikobeats deleted the ijjk/fix/dependency-conflict branch February 6, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants