Skip to content

Commit

Permalink
Revert "switch to open (#3788)"
Browse files Browse the repository at this point in the history
This reverts commit 84bab83.
  • Loading branch information
Stanzilla committed Sep 11, 2019
1 parent bc8207f commit ec259be
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions cli/index.js
Expand Up @@ -7,7 +7,7 @@ const {version} = require('../app/package');
const pify = require('pify');
const args = require('args');
const chalk = require('chalk');
const open = require('open');
const opn = require('opn');
const columnify = require('columnify');
const got = require('got');
const ora = require('ora');
Expand Down Expand Up @@ -130,7 +130,7 @@ args.command(['lsr', 'list-remote', 'ls-remote'], 'List plugins available on npm
args.command(['d', 'docs', 'h', 'home'], 'Open the npm page of a plugin', (name, args_) => {
const pluginName = args_[0];
assertPluginName(pluginName);
open(`http://ghub.io/${pluginName}`, {wait: false});
opn(`http://ghub.io/${pluginName}`, {wait: false});
process.exit(0);
});

Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -190,7 +190,7 @@
"json-loader": "0.5.7",
"mousetrap": "chabou/mousetrap#useCapture",
"ms": "2.1.1",
"open": "6.4.0",
"opn": "5.3.0",
"ora": "1.3.0",
"parse-url": "3.0.2",
"php-escape-shell": "1.0.0",
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
Expand Up @@ -4785,9 +4785,9 @@ onetime@^2.0.0:
dependencies:
mimic-fn "^1.0.0"

open@6.4.0:
version "6.4.0"
resolved "https://registry.npmjs.org/open/-/open-6.4.0.tgz#5c13e96d0dc894686164f18965ecfe889ecfc8a9"
opn@5.3.0:
version "5.3.0"
resolved "https://registry.yarnpkg.com/opn/-/opn-5.3.0.tgz#64871565c863875f052cfdf53d3e3cb5adb53b1c"
dependencies:
is-wsl "^1.1.0"

Expand Down

5 comments on commit ec259be

@Stanzilla
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesgeorge007 does not work on Windows yet, sorry 😕

@jamesgeorge007
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that's strange 🤔
It works like a charm in my case: Mevn-CLI

@jamesgeorge007
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stanzilla
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for this to land sindresorhus/open#146

@jamesgeorge007
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Please sign in to comment.