Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic publishing with lerna #133

Closed
wants to merge 6 commits into from

Conversation

thinkverse
Copy link
Contributor

To move forward with #127 and #131, I thought it'd be a good idea to make the micro-dev repository mimic micro. For that reason, I decided to copy vercel/micro#400 and add Lerna to support auto-publishing.

@leerob
Copy link
Member

leerob commented Jan 2, 2023

Are there advantages of using lerna here as a prerequisite for those other issues?

I haven't been using lerna in micro - just releasing manually, was actually thinking about removing it as it's a single package. Thoughts?

@thinkverse
Copy link
Contributor Author

thinkverse commented Jan 2, 2023

Are there advantages of using lerna here as a prerequisite for those other issues?

As I understood it, it helps with versioning and publishing, by making it easier to release new versions with a single command.

lerna version increments a package version, commits, and tags it.

lerna publish does what version does, but also published that version.

I haven't been using lerna in micro

I thought it was used there since @timneutkens added it, hence the reason for this PR. 🤷‍♂️ If it's not needed then feel free to close this. 🙂

@leerob
Copy link
Member

leerob commented Jan 3, 2023

Yeah I've just been using release followed by npm publish. Lerna is helpful when there's multiple packages!

Appreciate the effort here regardless 🙏

@leerob leerob closed this Jan 3, 2023
@thinkverse thinkverse deleted the auto-publishing branch January 3, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants