Add ESLint and TypeScript #458
Conversation
|
Amazing! Will dive into this and take a look. |
pmbanugo
force-pushed
the
typescript
branch
2 times, most recently
from
f3c66ec
to
1e19d20
Compare
| } | ||
|
|
||
| if (obj instanceof Stream || readable(obj)) { | ||
| //TODO: Wouldn't (obj instanceof Stream) be the only check here? Do we specifically need a Readable stream or a Stream object that's not of NodeJS Stream? |
There was a problem hiding this comment.
I'm not sure about this. The comment is for someone here to let me know why we do this. Or discuss later in the future if this is necessary.
|
Hi @leerob It's ready for review. |
|
I think we'll need to add a
|
@leerob I've updated the script, it should work now. |
|
That should work but it's failing 😓 I'm not sure why, but I'll check again. |
|
@leerob Updated... If it doesn't work this time, perhaps you can try clearing the cache and rerunning the build. |
|
It works! 🎉 |
Hi, @leerob just following up on this 😄 |
|
Planning to go ahead and merge/release #460, and then let's release this as a major version 👍 |
|
@leerob Do you want me to update my branch and use the reverted change, or go ahead with what I currently have with |
|
What do you think? I think we probably keep the breaking changes. |
|
I think we keep the breaking change because that way we can use it programmatically with fastify or something similar. I'll make the necessary changes and update the PR soon. |
BREAKING CHANGE: Switched to using ES2020 syntax and minimum Node engine to 14.5.0.
BREAKING CHANGE: Removes the deprecated options/arguments for starting the server. They are: - --port (-p) - --host (-h) - --unix-socket (-s)
|
I left it with the breaking change and updated the documentation |
Closes #457
This PR adds TypeScript and rewrites the library code using TypeScript.
Highlight: