Skip to content

Commit

Permalink
chore: fix some with-electron-typescript example setup (#18976)
Browse files Browse the repository at this point in the history
- Changed script `start` to `dev` and improved it #18934 adding commando to transpile electron code;
- Added some folders into `.gitignore`;
- Updated react to avoid issues as #18916

Fixes #18934
  • Loading branch information
davidsonsns committed Nov 9, 2020
1 parent c571f31 commit 019bbb2
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 32 deletions.
7 changes: 5 additions & 2 deletions examples/with-electron-typescript/.gitignore
Expand Up @@ -9,8 +9,8 @@
/coverage

# next.js
/.next/
/out/
.next/
out/

# production
/build
Expand All @@ -32,3 +32,6 @@ yarn-error.log*

# vercel
.vercel

# transpiled
main
12 changes: 6 additions & 6 deletions examples/with-electron-typescript/README.md
Expand Up @@ -25,12 +25,12 @@ yarn create next-app --example with-electron-typescript with-electron-typescript
Available commands:

```bash
"yarn build-renderer": build and transpile Next.js layer
"yarn build-electron": transpile electron layer
"yarn build": build both layers
"yarn start": start dev version
"yarn dist": create production elctron build
"yarn type-check": check TypeScript in project
"build-renderer": build and transpile Next.js layer
"build-electron": transpile electron layer
"build": build both layers
"dev": start dev version
"dist": create production elctron build
"type-check": check TypeScript in project
```

## Notes
Expand Down
48 changes: 24 additions & 24 deletions examples/with-electron-typescript/package.json
@@ -1,40 +1,40 @@
{
"name": "with-electron-typescript",
"productName": "ElectronTypescriptNext",
"version": "1.0.0",
"license": "MIT",
"main": "main/index.js",
"productName": "ElectronTypescriptNext",
"scripts": {
"clean": "rimraf dist main renderer/out renderer/.next",
"start": "electron .",
"build-renderer": "next build renderer && next export renderer",
"build-electron": "tsc -p electron-src",
"build": "yarn build-renderer && yarn build-electron",
"pack-app": "yarn build && electron-builder --dir",
"build-electron": "tsc -p electron-src",
"build-renderer": "next build renderer && next export renderer",
"clean": "rimraf dist main renderer/out renderer/.next",
"dev": "yarn build-electron && electron .",
"dist": "yarn build && electron-builder",
"pack-app": "yarn build && electron-builder --dir",
"type-check": "tsc"
},
"dependencies": {
"electron-is-dev": "^1.1.0",
"electron-next": "^3.1.5",
"react": "^17.0.0",
"react-dom": "^17.0.0"
},
"devDependencies": {
"@types/node": "^14.14.6",
"@types/react": "^16.9.9",
"@types/react-dom": "^16.9.9",
"electron": "^10.1.5",
"electron-builder": "^22.9.1",
"next": "latest",
"rimraf": "^3.0.0",
"typescript": "^4.0.5"
},
"build": {
"asar": true,
"files": [
"main",
"renderer/out"
]
},
"devDependencies": {
"@types/node": "^12.12.21",
"@types/react": "^16.9.17",
"@types/react-dom": "^16.9.4",
"electron": "^7.1.7",
"electron-builder": "^21.2.0",
"next": "latest",
"rimraf": "^3.0.0",
"typescript": "^3.7.4"
},
"dependencies": {
"electron-is-dev": "^1.1.0",
"electron-next": "^3.1.5",
"react": "^16.12.0",
"react-dom": "^16.12.0"
},
"license": "MIT"
}
}

0 comments on commit 019bbb2

Please sign in to comment.