Update return shape of generateStaticParams (#40965)

x-ref: [slack thread](https://vercel.slack.com/archives/C035J346QQL/p1664290658055079)
vercel · Sep 27, 2022 · 0f41a48 · 0f41a48
1 parent e0cc9cd
commit 0f41a48
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 28 deletions.
diff --git a/packages/next/build/utils.ts b/packages/next/build/utils.ts
@@ -1126,7 +1126,7 @@ export async function buildAppStaticPaths({
         const result = await curGenerate.generateStaticParams({ params })
         // TODO: validate the result is valid here or wait for
         // buildStaticPaths to validate?
-        for (const item of result.params) {
+        for (const item of result) {
           newParams.push({ ...params, ...item })
         }
       }

diff --git a/test/e2e/app-dir/app-static/app/blog/[author]/[slug]/page.js b/test/e2e/app-dir/app-static/app/blog/[author]/[slug]/page.js
@@ -20,34 +20,28 @@ export function generateStaticParams({ params }) {
 
   switch (params.author) {
     case 'tim': {
-      return {
-        params: [
-          {
-            slug: 'first-post',
-          },
-        ],
-      }
+      return [
+        {
+          slug: 'first-post',
+        },
+      ]
     }
     case 'seb': {
-      return {
-        params: [
-          {
-            slug: 'second-post',
-          },
-        ],
-      }
+      return [
+        {
+          slug: 'second-post',
+        },
+      ]
     }
     case 'styfle': {
-      return {
-        params: [
-          {
-            slug: 'first-post',
-          },
-          {
-            slug: 'second-post',
-          },
-        ],
-      }
+      return [
+        {
+          slug: 'first-post',
+        },
+        {
+          slug: 'second-post',
+        },
+      ]
     }
     default: {
       throw new Error(`unexpected author param received ${params.author}`)

diff --git a/test/e2e/app-dir/app-static/app/blog/[author]/layout.js b/test/e2e/app-dir/app-static/app/blog/[author]/layout.js
@@ -10,7 +10,5 @@ export default function Layout({ children, params }) {
 export function generateStaticParams({ params }) {
   console.log('/blog/[author] generateStaticParams', JSON.stringify(params))
 
-  return {
-    params: [{ author: 'tim' }, { author: 'seb' }, { author: 'styfle' }],
-  }
+  return [{ author: 'tim' }, { author: 'seb' }, { author: 'styfle' }]
 }