Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Align onRecoverableError callback between pages and app dir (#44161)
Should not re-throw the error on client for errors from `onRecoverableError` callback in pages, this PR share it as a same callback between pages and app dir follow up for #42589
- Loading branch information
Showing
3 changed files
with
21 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import { NEXT_DYNAMIC_NO_SSR_CODE } from '../shared/lib/no-ssr-error' | ||
|
||
export default function onRecoverableError(err: any) { | ||
// Using default react onRecoverableError | ||
// x-ref: https://github.com/facebook/react/blob/d4bc16a7d69eb2ea38a88c8ac0b461d5f72cdcab/packages/react-dom/src/client/ReactDOMRoot.js#L83 | ||
const defaultOnRecoverableError = | ||
typeof reportError === 'function' | ||
? // In modern browsers, reportError will dispatch an error event, | ||
// emulating an uncaught JavaScript error. | ||
reportError | ||
: (error: any) => { | ||
window.console.error(error) | ||
} | ||
|
||
// Skip certain custom errors which are not expected to be reported on client | ||
if (err.digest === NEXT_DYNAMIC_NO_SSR_CODE) return | ||
defaultOnRecoverableError(err) | ||
} |