Skip to content

Commit

Permalink
Fix extra block element in body (#49034)
Browse files Browse the repository at this point in the history
This PR adds `position: absolute` to the router announcer container so
it won't affect the layout of siblings / parents.

Closes #48087.

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
shuding and kodiakhq[bot] committed May 1, 2023
1 parent 5bc1e65 commit 1a71bea
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ function getAnnouncerNode() {
return existingAnnouncer.shadowRoot.childNodes[0] as HTMLElement
} else {
const container = document.createElement(ANNOUNCER_TYPE)
container.style.cssText = 'position:absolute'
const announcer = document.createElement('div')
announcer.setAttribute('aria-live', 'assertive')
announcer.setAttribute('id', ANNOUNCER_ID)
Expand Down

0 comments on commit 1a71bea

Please sign in to comment.