Skip to content

Commit

Permalink
chore: make sure polyfills are built for pnpm dev (#40335)
Browse files Browse the repository at this point in the history
Utilize `turbo` for `dev`, and make sure polyfills are built. Fixes #40334

Another option would be to document that an initial `pnpm build` is necessary in  [`CONTRIBUTING.md`](https://github.com/vercel/next.js/blob/canary/contributing.md#developing).

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)
  • Loading branch information
balazsorban44 committed Sep 30, 2022
1 parent 73b4739 commit 24f573f
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 17 deletions.
4 changes: 2 additions & 2 deletions package.json
Expand Up @@ -11,7 +11,7 @@
"clean": "pnpm lerna clean -y && pnpm lerna bootstrap && pnpm lerna exec 'rm -rf ./dist'",
"build": "turbo run build",
"lerna": "lerna",
"dev": "lerna run dev --stream --parallel",
"dev": "turbo run dev --parallel",
"test-types": "pnpm tsc",
"test-unit": "pnpm jest test/unit/",
"test-dev": "cross-env NEXT_TEST_MODE=dev pnpm testheadless",
Expand All @@ -23,7 +23,7 @@
"genstats": "cross-env LOCAL_STATS=true node .github/actions/next-stats-action/src/index.js",
"git-reset": "git reset --hard HEAD",
"git-clean": "git clean -d -x -e node_modules -e packages -f",
"lint-typescript": "lerna run typescript",
"lint-typescript": "turbo run typescript",
"lint-eslint": "eslint . --ext js,jsx,ts,tsx --max-warnings=0 --config .eslintrc.json --no-eslintrc",
"lint-no-typescript": "run-p prettier-check lint-eslint",
"lint": "run-p test-types lint-typescript prettier-check lint-eslint lint-language",
Expand Down
1 change: 1 addition & 0 deletions packages/next-polyfill-module/package.json
Expand Up @@ -10,6 +10,7 @@
},
"scripts": {
"build": "microbundle -i src/index.js -o dist/polyfill-module.js -f iife --no-sourcemap --external none --no-pkg-main",
"dev": "pnpm build",
"prepublishOnly": "cd ../../ && turbo run build"
},
"devDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/next-polyfill-nomodule/package.json
Expand Up @@ -10,6 +10,7 @@
},
"scripts": {
"build": "microbundle -i src/index.js -o dist/polyfill-nomodule.js -f iife --no-sourcemap --external none --no-pkg-main",
"dev": "pnpm build",
"prepublishOnly": "cd ../../ && turbo run build"
},
"devDependencies": {
Expand Down
10 changes: 5 additions & 5 deletions packages/next/package.json
Expand Up @@ -120,11 +120,11 @@
"@hapi/accept": "5.0.2",
"@napi-rs/cli": "2.7.0",
"@napi-rs/triples": "1.1.0",
"@next/polyfill-module": "12.3.2-canary.15",
"@next/polyfill-nomodule": "12.3.2-canary.15",
"@next/react-dev-overlay": "12.3.2-canary.15",
"@next/react-refresh-utils": "12.3.2-canary.15",
"@next/swc": "12.3.2-canary.15",
"@next/polyfill-module": "workspace:*",
"@next/polyfill-nomodule": "workspace:*",
"@next/react-dev-overlay": "workspace:*",
"@next/react-refresh-utils": "workspace:*",
"@next/swc": "workspace:*",
"@segment/ajv-human-errors": "2.1.2",
"@taskr/clear": "1.1.0",
"@taskr/esnext": "1.1.0",
Expand Down
17 changes: 8 additions & 9 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion turbo.json
@@ -1,4 +1,5 @@
{
"$schema": "https://turborepo.org/schema.json",
"pipeline": {
"build-native": {
"dependsOn": ["^build-native"],
Expand All @@ -15,6 +16,11 @@
"build": {
"dependsOn": ["^build"],
"outputs": ["dist/**"]
}
},
"dev": {
"dependsOn": ["^dev"],
"outputs": ["dist/**"]
},
"typescript": {}
}
}

0 comments on commit 24f573f

Please sign in to comment.