Skip to content

Commit

Permalink
Turbopack: remove server addr (#61932)
Browse files Browse the repository at this point in the history
### What?

remove server_addr option

### Why?

We no longer need the server addr for bundling.


Closes PACK-2462
  • Loading branch information
sokra committed Feb 13, 2024
1 parent 898f74e commit 310c9be
Show file tree
Hide file tree
Showing 9 changed files with 50 additions and 123 deletions.
68 changes: 34 additions & 34 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ swc_core = { version = "0.90.7", features = [
testing = { version = "0.35.18" }

# Turbo crates
turbopack-binding = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240213.2" }
turbopack-binding = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240213.4" }
# [TODO]: need to refactor embed_directory! macro usages, as well as resolving turbo_tasks::function, macros..
turbo-tasks = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240213.2" }
turbo-tasks = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240213.4" }
# [TODO]: need to refactor embed_directory! macro usage in next-core
turbo-tasks-fs = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240213.2" }
turbo-tasks-fs = { git = "https://github.com/vercel/turbo.git", tag = "turbopack-240213.4" }

# General Deps

Expand Down
8 changes: 0 additions & 8 deletions packages/next-swc/crates/napi/src/next_api/project.rs
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ pub struct NapiProjectOptions {
/// A map of environment variables which should get injected at compile
/// time.
pub define_env: NapiDefineEnv,

/// The address of the dev server.
pub server_addr: String,
}

/// [NapiProjectOptions] with all fields optional.
Expand Down Expand Up @@ -124,9 +121,6 @@ pub struct NapiPartialProjectOptions {
/// A map of environment variables which should get injected at compile
/// time.
pub define_env: Option<NapiDefineEnv>,

/// The address of the dev server.
pub server_addr: Option<String>,
}

#[napi(object)]
Expand Down Expand Up @@ -157,7 +151,6 @@ impl From<NapiProjectOptions> for ProjectOptions {
.map(|var| (var.name, var.value))
.collect(),
define_env: val.define_env.into(),
server_addr: val.server_addr,
}
}
}
Expand All @@ -174,7 +167,6 @@ impl From<NapiPartialProjectOptions> for PartialProjectOptions {
.env
.map(|env| env.into_iter().map(|var| (var.name, var.value)).collect()),
define_env: val.define_env.map(|env| env.into()),
server_addr: val.server_addr,
}
}
}
Expand Down

0 comments on commit 310c9be

Please sign in to comment.