Remove browser.refresh in app tests (#44186)

vercel · Dec 20, 2022 · 39f30fb · 39f30fb
1 parent 6640846
commit 39f30fb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 26 deletions.
diff --git a/test/development/acceptance-app/ReactRefreshRegression.test.ts b/test/development/acceptance-app/ReactRefreshRegression.test.ts
@@ -145,8 +145,7 @@ describe('ReactRefreshRegression app', () => {
   })
 
   // https://github.com/vercel/next.js/issues/13978
-  // TODO-APP: fix case where server component is moved to a client component
-  test.skip('can fast refresh a page with dynamic rendering', async () => {
+  test('can fast refresh a page with dynamic rendering', async () => {
     const { session, cleanup } = await sandbox(next)
 
     await session.patch(
@@ -216,8 +215,7 @@ describe('ReactRefreshRegression app', () => {
   })
 
   // https://github.com/vercel/next.js/issues/13978
-  // TODO-APP: fix case where server component is moved to a client component
-  test.skip('can fast refresh a page with config', async () => {
+  test('can fast refresh a page with config', async () => {
     const { session, cleanup } = await sandbox(next)
 
     await session.patch(
@@ -264,17 +262,14 @@ describe('ReactRefreshRegression app', () => {
   })
 
   // https://github.com/vercel/next.js/issues/11504
-  // TODO-APP: fix case where error is not resolved to source correctly.
   test('shows an overlay for anonymous function server-side error', async () => {
-    const { session, browser, cleanup } = await sandbox(next)
+    const { session, cleanup } = await sandbox(next)
 
     await session.patch(
       'app/page.js',
       `export default function () { throw new Error('boom'); }`
     )
 
-    await browser.refresh()
-
     expect(await session.hasRedbox(true)).toBe(true)
 
     const source = await session.getRedboxSource()
@@ -287,15 +282,13 @@ describe('ReactRefreshRegression app', () => {
   })
 
   test('shows an overlay for server-side error in server component', async () => {
-    const { session, browser, cleanup } = await sandbox(next)
+    const { session, cleanup } = await sandbox(next)
 
     await session.patch(
       'app/page.js',
       `export default function Page() { throw new Error('boom'); }`
     )
 
-    await browser.refresh()
-
     expect(await session.hasRedbox(true)).toBe(true)
 
     const source = await session.getRedboxSource()
@@ -308,16 +301,14 @@ describe('ReactRefreshRegression app', () => {
   })
 
   test('shows an overlay for server-side error in client component', async () => {
-    const { session, browser, cleanup } = await sandbox(next)
+    const { session, cleanup } = await sandbox(next)
 
     await session.patch(
       'app/page.js',
       `'use client'
       export default function Page() { throw new Error('boom'); }`
     )
 
-    await browser.refresh()
-
     expect(await session.hasRedbox(true)).toBe(true)
 
     const source = await session.getRedboxSource()

diff --git a/test/development/acceptance-app/server-components.test.ts b/test/development/acceptance-app/server-components.test.ts
@@ -22,7 +22,7 @@ describe('Error Overlay for server components', () => {
 
   describe('createContext called in Server Component', () => {
     it('should show error when React.createContext is called', async () => {
-      const { session, browser, cleanup } = await sandbox(
+      const { session, cleanup } = await sandbox(
         next,
         new Map([
           [
@@ -43,9 +43,6 @@ describe('Error Overlay for server components', () => {
         ])
       )
 
-      // TODO-APP: currently requires a full reload because moving from a client component to a server component isn't causing a Fast Refresh yet.
-      await browser.refresh()
-
       expect(await session.hasRedbox(true)).toBe(true)
       await check(async () => {
         expect(await session.getRedboxSource(true)).toContain(
@@ -61,7 +58,7 @@ describe('Error Overlay for server components', () => {
     })
 
     it('should show error when React.createContext is called in external package', async () => {
-      const { session, browser, cleanup } = await sandbox(
+      const { session, cleanup } = await sandbox(
         next,
         new Map([
           [
@@ -97,9 +94,6 @@ describe('Error Overlay for server components', () => {
         ])
       )
 
-      // TODO-APP: currently requires a full reload because moving from a client component to a server component isn't causing a Fast Refresh yet.
-      await browser.refresh()
-
       expect(await session.hasRedbox(true)).toBe(true)
 
       await check(async () => {
@@ -117,7 +111,7 @@ describe('Error Overlay for server components', () => {
     })
 
     it('should show error when createContext is called in external package', async () => {
-      const { session, browser, cleanup } = await sandbox(
+      const { session, cleanup } = await sandbox(
         next,
         new Map([
           [
@@ -153,9 +147,6 @@ describe('Error Overlay for server components', () => {
         ])
       )
 
-      // TODO-APP: currently requires a full reload because moving from a client component to a server component isn't causing a Fast Refresh yet.
-      await browser.refresh()
-
       expect(await session.hasRedbox(true)).toBe(true)
 
       await check(async () => {