Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
alexkirsz committed Jun 5, 2023
1 parent 8e21792 commit 42f033d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 0 additions & 3 deletions packages/next-swc/crates/next-build/src/next_build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -483,23 +483,20 @@ async fn workspace_fs(
) -> Result<FileSystemVc> {
let disk_fs = DiskFileSystemVc::new("workspace".to_string(), workspace_root.to_string());
handle_issues(disk_fs, issue_reporter).await?;
disk_fs.await?.start_watching()?;
Ok(disk_fs.into())
}

#[turbo_tasks::function]
async fn node_fs(node_root: &str, issue_reporter: IssueReporterVc) -> Result<FileSystemVc> {
let disk_fs = DiskFileSystemVc::new("node".to_string(), node_root.to_string());
handle_issues(disk_fs, issue_reporter).await?;
disk_fs.await?.start_watching()?;
Ok(disk_fs.into())
}

#[turbo_tasks::function]
async fn client_fs(client_root: &str, issue_reporter: IssueReporterVc) -> Result<FileSystemVc> {
let disk_fs = DiskFileSystemVc::new("client".to_string(), client_root.to_string());
handle_issues(disk_fs, issue_reporter).await?;
disk_fs.await?.start_watching()?;
Ok(disk_fs.into())
}

Expand Down
3 changes: 3 additions & 0 deletions packages/next/src/build/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,9 @@ export default async function build(
}

if (turboNextBuild) {
// TODO(WEB-397) This is a temporary workaround to allow for filtering a
// subset of pages when building with --experimental-turbo, until we
// have complete support for all pages.
if (process.env.NEXT_TURBO_FILTER_PAGES) {
const filterPages = process.env.NEXT_TURBO_FILTER_PAGES.split(',')
pageKeys.pages = pageKeys.pages.filter((page) => {
Expand Down

0 comments on commit 42f033d

Please sign in to comment.