feat(create-next-app): add @types/react-dom to TS template (#34623)

* Add @types/react-dom devDependencies * fix: eslint error * fix: eslint error 2
vercel · Feb 24, 2022 · 58ab94b · 58ab94b
1 parent c9863c8
commit 58ab94b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/create-next-app/create-app.ts b/packages/create-next-app/create-app.ts
@@ -234,7 +234,12 @@ export async function createApp({
      * TypeScript projects will have type definitions and other devDependencies.
      */
     if (typescript) {
-      devDependencies.push('typescript', '@types/react', '@types/node')
+      devDependencies.push(
+        'typescript',
+        '@types/react',
+        '@types/node',
+        '@types/react-dom'
+      )
     }
     /**
      * Install package.json dependencies if they exist.

diff --git a/test/integration/create-next-app/index.test.js b/test/integration/create-next-app/index.test.js
@@ -143,6 +143,7 @@ describe('create next app', () => {
       expect(Object.keys(pkgJSON.devDependencies)).toEqual([
         '@types/node',
         '@types/react',
+        '@types/react-dom',
         'eslint',
         'eslint-config-next',
         'typescript',