Skip to content

Commit

Permalink
fix: Disable tracing/release_max_level_off for wasm, too (#49639)
Browse files Browse the repository at this point in the history
### What?

Along with swc-project/plugins#182, this PR will
allow using trace-level logging for debugging turboapck.

### Why?

Requested by @sokra 

x-ref: https://vercel.slack.com/archives/C03EWR7LGEN/p1683738076476839

### How?

Closes WEB-1035
  • Loading branch information
kdy1 committed May 15, 2023
1 parent ca32dec commit 5aaa6ff
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build_test_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1537,7 +1537,7 @@ jobs:
run: node scripts/normalize-version-bump.js

- name: Build
run: turbo run build-wasm -- --target ${{ matrix.target }}
run: turbo run build-wasm -- --target ${{ matrix.target }} --features tracing/release_max_level_info

- name: Add target to folder name
run: '[[ -d "packages/next-swc/crates/wasm/pkg" ]] && mv packages/next-swc/crates/wasm/pkg packages/next-swc/crates/wasm/pkg-${{ matrix.target }} || ls packages/next-swc/crates/wasm'
Expand Down Expand Up @@ -1602,7 +1602,7 @@ jobs:

- name: Build
if: ${{needs.build.outputs.docsChange == 'nope'}}
run: turbo run build-wasm --cache-dir=".turbo" -- --target nodejs --dev
run: turbo run build-wasm --cache-dir=".turbo" -- --target nodejs --dev --features tracing/release_max_level_info

- name: Add target to folder name
if: ${{needs.build.outputs.docsChange == 'nope'}}
Expand Down
5 changes: 1 addition & 4 deletions packages/next-swc/crates/wasm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ parking_lot_core = "=0.8.0"
path-clean = "0.1"
serde = { version = "1", features = ["derive"] }
serde_json = "1"
tracing = { version = "0.1.37", features = [
"release_max_level_off",
"max_level_off",
] }
tracing = { version = "0.1.37" }
wasm-bindgen = { version = "0.2", features = ["enable-interning"] }
wasm-bindgen-futures = "0.4.8"
getrandom = { version = "0.2.5", optional = true, default-features = false }
Expand Down

0 comments on commit 5aaa6ff

Please sign in to comment.