move next/script to pages/_app in script loader integration tests (…

…#27626)
vercel · Aug 3, 2021 · 5ded742 · 5ded742
1 parent 28c13bd
commit 5ded742
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 18 deletions.
diff --git a/test/integration/script-loader/pages/_app.js b/test/integration/script-loader/pages/_app.js
@@ -1,7 +1,28 @@
+import Script from 'next/script'
+
 import '../styles/styles.css'
 
 function MyApp({ Component, pageProps }) {
-  return <Component {...pageProps} />
+  return (
+    <>
+      <Script
+        id="documentAfterInteractive"
+        src="https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.20/lodash.min.js?a=documentAfterInteractive"
+        strategy="afterInteractive"
+      />
+      <Script
+        id="documentLazyOnload"
+        src="https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.20/lodash.min.js?a=documentLazyOnload"
+        strategy="lazyOnload"
+      />
+      <Script
+        id="documentBeforeInteractive"
+        src="https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.20/lodash.min.js?a=documentBeforeInteractive"
+        strategy="beforeInteractive"
+      />
+      <Component {...pageProps} />
+    </>
+  )
 }
 
 export default MyApp
diff --git a/test/integration/script-loader/pages/_document.js b/test/integration/script-loader/pages/_document.js
@@ -1,7 +1,6 @@
 import * as React from 'react'
 /// @ts-ignore
 import Document, { Main, NextScript, Head } from 'next/document'
-import Script from 'next/script'
 
 export default class MyDocument extends Document {
   constructor(props) {
@@ -20,26 +19,11 @@ export default class MyDocument extends Document {
             rel="stylesheet"
             href="https://fonts.googleapis.com/css?family=Voces"
           />
-          <Script
-            id="documentAfterInteractive"
-            src="https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.20/lodash.min.js?a=documentAfterInteractive"
-            strategy="afterInteractive"
-          ></Script>
-          <Script
-            id="documentLazyOnload"
-            src="https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.20/lodash.min.js?a=documentLazyOnload"
-            strategy="lazyOnload"
-          ></Script>
-          <Script
-            id="documentBeforeInteractive"
-            src="https://cdnjs.cloudflare.com/ajax/libs/lodash.js/4.17.20/lodash.min.js?a=documentBeforeInteractive"
-            strategy="beforeInteractive"
-          ></Script>
         </Head>
         <body>
           <Main />
           <NextScript />
-          <div id="text"></div>
+          <div id="text" />
         </body>
       </html>
     )