Skip to content

Commit

Permalink
Remove reload on serverComponentChanges in pages (#41020)
Browse files Browse the repository at this point in the history
This caused unexpected full page reloads when viewing pages in `pages`. E.g. when navigating to `app`. Since `app` is the only place you can have server components now this is no longer needed.


## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
  • Loading branch information
timneutkens committed Sep 29, 2022
1 parent 42713fb commit 6fefa98
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions packages/next/client/dev/error-overlay/hot-dev-client.js
Expand Up @@ -260,16 +260,6 @@ function processMessage(e) {
)
return handleSuccess()
}

case 'serverComponentChanges': {
sendMessage(
JSON.stringify({
event: 'server-component-reload-page',
clientId: window.__nextDevClientId,
})
)
return window.location.reload()
}
default: {
if (customHmrEventHandler) {
customHmrEventHandler(obj)
Expand Down

0 comments on commit 6fefa98

Please sign in to comment.