Skip to content

Commit

Permalink
Remove native-url Again (#10526)
Browse files Browse the repository at this point in the history
* Remove `native-url` Again

* update comment

* update sizes
  • Loading branch information
Timer committed Feb 13, 2020
1 parent d5222f8 commit 71019e7
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 12 deletions.
5 changes: 3 additions & 2 deletions packages/next/build/webpack-config.ts
Expand Up @@ -106,8 +106,9 @@ function getOptimizedAliases(
'object.assign/polyfill': path.join(shimAssign, 'polyfill.js'),
'object.assign/shim': path.join(shimAssign, 'shim.js'),

// Replace: full URL polyfill with platform-based polyfill
url: require.resolve('native-url'),
// TODO: re-enable when `native-url` supports Safari 10
// // Replace: full URL polyfill with platform-based polyfill
// url: require.resolve('native-url'),
}
)
}
Expand Down
1 change: 0 additions & 1 deletion packages/next/package.json
Expand Up @@ -115,7 +115,6 @@
"lru-cache": "5.1.1",
"mini-css-extract-plugin": "0.8.0",
"mkdirp": "0.5.1",
"native-url": "0.2.6",
"node-fetch": "2.6.0",
"object-assign": "4.1.1",
"ora": "3.4.0",
Expand Down
4 changes: 2 additions & 2 deletions test/integration/size-limit/test/index.test.js
Expand Up @@ -80,7 +80,7 @@ describe('Production response size', () => {
)

// These numbers are without gzip compression!
const delta = responseSizesBytes - 226 * 1024
const delta = responseSizesBytes - 233 * 1024
expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
})
Expand All @@ -100,7 +100,7 @@ describe('Production response size', () => {
)

// These numbers are without gzip compression!
const delta = responseSizesBytes - 195 * 1024
const delta = responseSizesBytes - 201 * 1024
expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
})
Expand Down
7 changes: 0 additions & 7 deletions yarn.lock
Expand Up @@ -10918,13 +10918,6 @@ native-or-bluebird@^1.2.0:
resolved "https://registry.yarnpkg.com/native-or-bluebird/-/native-or-bluebird-1.2.0.tgz#39c47bfd7825d1fb9ffad32210ae25daadf101c9"
integrity sha1-OcR7/Xgl0fuf+tMiEK4l2q3xAck=

native-url@0.2.6:
version "0.2.6"
resolved "https://registry.yarnpkg.com/native-url/-/native-url-0.2.6.tgz#ca1258f5ace169c716ff44eccbddb674e10399ae"
integrity sha512-k4bDC87WtgrdD362gZz6zoiXQrl40kYlBmpfmSjwRO1VU0V5ccwJTlxuE72F6m3V0vc1xOf6n3UCP9QyerRqmA==
dependencies:
querystring "^0.2.0"

natural-compare@^1.4.0:
version "1.4.0"
resolved "https://registry.yarnpkg.com/natural-compare/-/natural-compare-1.4.0.tgz#4abebfeed7541f2c27acfb29bdbbd15c8d5ba4f7"
Expand Down

0 comments on commit 71019e7

Please sign in to comment.