Apply suggestion from ForsakenHarmony

vercel · Jun 8, 2023 · 81c0f18 · 81c0f18
1 parent 9e9e407
commit 81c0f18
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 20 deletions.
diff --git a/test/e2e/typescript-version-no-warning/typescript-version-no-warning.test.ts b/test/e2e/typescript-version-no-warning/typescript-version-no-warning.test.ts
@@ -9,16 +9,15 @@ createNextDescribe(
   },
   ({ next, isNextDeploy, isNextDev }) => {
     if (isNextDeploy || isNextDev) {
-      it('should skip', async () => {
-        expect(1).toBe(1)
-      })
-    } else {
-      it('should not print warning when new typescript version is used with next build', async () => {
-        await next.start().catch(() => {})
-        expect(next.cliOutput).not.toContain(
-          'Minimum recommended TypeScript version is'
-        )
-      })
+      it('should skip', () => {})
+      return
     }
+
+    it('should not print warning when new typescript version is used with next build', async () => {
+      await next.start().catch(() => {})
+      expect(next.cliOutput).not.toContain(
+        'Minimum recommended TypeScript version is'
+      )
+    })
   }
 )
diff --git a/test/e2e/typescript-version-warning/typescript-version-warning.test.ts b/test/e2e/typescript-version-warning/typescript-version-warning.test.ts
@@ -12,16 +12,15 @@ createNextDescribe(
   },
   ({ next, isNextDeploy, isNextDev }) => {
     if (isNextDeploy || isNextDev) {
-      it('should skip', async () => {
-        expect(1).toBe(1)
-      })
-    } else {
-      it('should print warning when old typescript version is used with next build', async () => {
-        await next.start().catch(() => {})
-        expect(next.cliOutput).toContain(
-          'warn Minimum recommended TypeScript version is v4.5.2, older versions can potentially be incompatible with Next.js. Detected: 4.0.6'
-        )
-      })
+      it('should skip', () => {})
+      return
     }
+
+    it('should print warning when old typescript version is used with next build', async () => {
+      await next.start().catch(() => {})
+      expect(next.cliOutput).toContain(
+        'warn Minimum recommended TypeScript version is v4.5.2, older versions can potentially be incompatible with Next.js. Detected: 4.0.6'
+      )
+    })
   }
 )