Allowing skipping local selenium server when not needed (#10312)

* Disable local selenium server when not needed * Disable skipping for firefox as it appears to be needed still
vercel · Jan 28, 2020 · 8581172 · 8581172
1 parent 6a88ec1
commit 8581172
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/build_test_deploy.yml b/.github/workflows/build_test_deploy.yml
@@ -80,6 +80,7 @@ jobs:
     env:
       NEXT_TELEMETRY_DISABLED: 1
       BROWSERSTACK: true
+      SKIP_LOCAL_SELENIUM_SERVER: true
       BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }}
       BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
     steps:

diff --git a/test/jest-environment.js b/test/jest-environment.js
@@ -4,7 +4,10 @@ const getPort = require('get-port')
 const seleniumServer = require('selenium-standalone')
 const NodeEnvironment = require('jest-environment-node')
 
-const { BROWSER_NAME: browserName = 'chrome' } = process.env
+const {
+  BROWSER_NAME: browserName = 'chrome',
+  SKIP_LOCAL_SELENIUM_SERVER,
+} = process.env
 
 const newTabPg = `
 <!DOCTYPE html>
@@ -38,7 +41,7 @@ class CustomEnvironment extends NodeEnvironment {
 
     let seleniumServerPort
 
-    if (browserName !== 'chrome') {
+    if (browserName !== 'chrome' && SKIP_LOCAL_SELENIUM_SERVER !== 'true') {
       console.log('Installing selenium server')
       await new Promise((resolve, reject) => {
         seleniumServer.install(err => {