Skip to content

Commit

Permalink
Update Player.tsx to improve code readability and styling. (#50275)
Browse files Browse the repository at this point in the history
Updated the demo player component to have more consistent styling and
format.

I thought this could be some nice spring cleaning for the community 🧹 

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation or adding/fixing Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md



## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
  • Loading branch information
Bowens20832 and ijjk committed Jun 14, 2023
1 parent 2ce15c4 commit 862f556
Showing 1 changed file with 35 additions and 3 deletions.
38 changes: 35 additions & 3 deletions examples/with-videojs/components/Player.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,51 @@ import videojs from 'video.js'
import 'videojs-youtube'

interface PlayerProps {
/**
*
*/
techOrder: string[]
/**
* Is autoplay enabled for this video?
*/
autoplay: boolean
/**
* Should this video have controls?
*/
controls: boolean
sources: { src: string; type: string }[]
/**
* A list of video sources.
*/
sources: {
/**
* The source url.
*/
src: string
/**
* The type of source
*/
type: string
}[]
}

export default function Player(props: PlayerProps) {
/**
* A simple video player component for displaying videos from external websites.
* @returns A Video.js video player element.
*/
const Player = (props: PlayerProps) => {
const [videoEl, setVideoEl] = useState<HTMLVideoElement | null>(null)
const onVideo = useCallback((el: HTMLVideoElement) => {
setVideoEl(el)
}, [])

useEffect(() => {
if (videoEl == null) return
if (videoEl == null) {
return
}

// our video.js player
const player = videojs(videoEl, props)

return () => {
player.dispose()
}
Expand All @@ -32,3 +62,5 @@ export default function Player(props: PlayerProps) {
</>
)
}

export default Player

0 comments on commit 862f556

Please sign in to comment.