Change invalid internal upstream image error code (#39334)

fixes #39312 this is more consistent with other errors an invalid image should cause a validation error and not a server error
vercel · Aug 5, 2022 · 869a2fe · 869a2fe
1 parent b402787
commit 869a2fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/next/server/image-optimizer.ts b/packages/next/server/image-optimizer.ts
@@ -511,7 +511,7 @@ export async function imageOptimizer(
       }
     } else {
       throw new ImageError(
-        500,
+        400,
         'Unable to optimize image and unable to fallback to upstream image'
       )
     }

diff --git a/test/integration/image-optimizer/test/util.js b/test/integration/image-optimizer/test/util.js
@@ -766,7 +766,7 @@ export function runTests(ctx) {
     const query = { url, w: ctx.w, q: 39 }
     const opts = { headers: { accept: 'image/webp' } }
     const res = await fetchViaHTTP(ctx.appPort, '/_next/image', query, opts)
-    expect(res.status).toBe(500)
+    expect(res.status).toBe(400)
     expect(await res.text()).toBe(
       `Unable to optimize image and unable to fallback to upstream image`
     )