Skip to content

Commit

Permalink
Update comments for the web server (#35366)
Browse files Browse the repository at this point in the history
The web server is used as minimal mode, whereas public file handling, envs and compression are both handled by the upper layer (edge runtime if deployed serverlessly, or node server if self-hosted).

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
  • Loading branch information
shuding committed Mar 16, 2022
1 parent 853442d commit 91136d2
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions packages/next/server/web-server.ts
Expand Up @@ -31,7 +31,8 @@ export default class NextWebServer extends BaseServer {
}
}
protected handleCompression() {
// @TODO
// For the web server layer, compression is automatically handled by the
// upstream proxy (edge runtime or node server) and we can simply skip here.
}
protected getRoutesManifest() {
return {
Expand All @@ -49,14 +50,15 @@ export default class NextWebServer extends BaseServer {
return ''
}
protected getPublicDir() {
// @TODO
// Public files are not handled by the web server.
return ''
}
protected getBuildId() {
return (globalThis as any).__server_context.buildId
}
protected loadEnvConfig() {
// @TODO
// The web server does not need to load the env config. This is done by the
// runtime already.
}
protected getHasStaticDir() {
return false
Expand Down

0 comments on commit 91136d2

Please sign in to comment.