Skip to content

Commit

Permalink
Add missing @napi-rs/cli devDependency to next-swc (#39164)
Browse files Browse the repository at this point in the history
Otherwise build-native fails with "napi: command not found.".

Alternatively, this is missing from this package's devDependencies.



## Documentation / Examples

- [x] Make sure the linting passes by running `pnpm lint`
- [x] The examples guidelines are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing.md#adding-examples)

P.S.: local copy fails `pnpm lint` due to the `target` subfolder with intermediate rust build artifacts... should I add a `.prettierignore` update to exclude `/packages/next-swc/target/`?

Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
  • Loading branch information
Jessidhia and ijjk committed Jul 30, 2022
1 parent 9a1b756 commit 97ab23f
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 7 deletions.
4 changes: 3 additions & 1 deletion .prettierignore
Expand Up @@ -12,6 +12,8 @@ packages/react-dev-overlay/lib/**
lerna.json
.github/actions/next-stats-action/.work
packages/next-swc/crates/**/*
packages/next-swc/target/**/*
packages/next-swc/native/**/*
packages/next-codemod/transforms/__testfixtures__/**/*
packages/next-codemod/transforms/__tests__/**/*
packages/next-codemod/**/*.js
Expand All @@ -21,4 +23,4 @@ test-timings.json
test/**/out/**
bench/nested-deps/pages/**/*
bench/nested-deps/components/**/*
pnpm-lock.yaml
pnpm-lock.yaml
3 changes: 3 additions & 0 deletions packages/next-swc/package.json
Expand Up @@ -24,5 +24,8 @@
"aarch64-pc-windows-msvc"
]
}
},
"devDependencies": {
"@napi-rs/cli": "2.7.0"
}
}
2 changes: 1 addition & 1 deletion packages/next/package.json
Expand Up @@ -119,7 +119,7 @@
"@babel/types": "7.18.0",
"@edge-runtime/primitives": "1.1.0-beta.23",
"@hapi/accept": "5.0.2",
"@napi-rs/cli": "2.4.4",
"@napi-rs/cli": "2.7.0",
"@napi-rs/triples": "1.1.0",
"@next/polyfill-module": "12.2.4-canary.8",
"@next/polyfill-nomodule": "12.2.4-canary.8",
Expand Down
13 changes: 8 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 97ab23f

Please sign in to comment.