Measure getStaticProps, getServerSideProps (#10800)

* Measure `getStaticProps`, `getServerSideProps` * Test new fields
vercel · Mar 3, 2020 · a5d0cb9 · a5d0cb9
1 parent ad1a061
commit a5d0cb9
Show file tree

Hide file tree

Showing 7 changed files with 47 additions and 3 deletions.
diff --git a/packages/next/build/index.ts b/packages/next/build/index.ts
@@ -815,7 +815,11 @@ export default async function build(dir: string, conf = null): Promise<void> {
     eventBuildOptimize(pagePaths, {
       durationInSeconds: analysisEnd[0],
       staticPageCount: staticPages.size,
-      ssrPageCount: pagePaths.length - staticPages.size,
+      staticPropsPageCount: ssgPages.size,
+      serverPropsPageCount: serverPropsPages.size,
+      ssrPageCount:
+        pagePaths.length -
+        (staticPages.size + ssgPages.size + serverPropsPages.size),
       hasStatic404: useStatic404,
     })
   )

diff --git a/packages/next/telemetry/events/build.ts b/packages/next/telemetry/events/build.ts
@@ -37,6 +37,8 @@ type EventBuildOptimized = {
   durationInSeconds: number
   totalPageCount: number
   staticPageCount: number
+  staticPropsPageCount: number
+  serverPropsPageCount: number
   ssrPageCount: number
   hasDunderPages: boolean
   hasTestPages: boolean

diff --git a/test/integration/telemetry/pages/gip.js b/test/integration/telemetry/pages/gip.js
@@ -0,0 +1,7 @@
+function A() {
+  return 'Hello World'
+}
+
+A.getInitialProps = () => ({ foo: 'bar' })
+
+export default A
diff --git a/test/integration/telemetry/pages/gssp.js b/test/integration/telemetry/pages/gssp.js
@@ -0,0 +1,5 @@
+export default () => 'Hello World'
+
+export function getServerSideProps() {
+  return { props: {} }
+}
diff --git a/test/integration/telemetry/pages/ssg.js b/test/integration/telemetry/pages/ssg.js
@@ -0,0 +1,5 @@
+export default () => 'Hello World'
+
+export function getStaticProps() {
+  return { props: {} }
+}
diff --git a/test/integration/telemetry/pages/ssg/[dynamic].js b/test/integration/telemetry/pages/ssg/[dynamic].js
@@ -0,0 +1,9 @@
+export default () => 'Hello World'
+
+export function getStaticProps() {
+  return { props: {} }
+}
+
+export function getStaticPaths() {
+  return { paths: [], fallback: true }
+}
diff --git a/test/integration/telemetry/test/index.test.js b/test/integration/telemetry/test/index.test.js
@@ -224,8 +224,6 @@ describe('Telemetry CLI', () => {
       path.join(appDir, 'package.babel')
     )
 
-    console.log(stderr)
-
     const event = /NEXT_CLI_SESSION_STARTED[\s\S]+?{([\s\S]+?)}/
       .exec(stderr)
       .pop()
@@ -324,6 +322,20 @@ describe('Telemetry CLI', () => {
     expect(event1).toMatch(/hasStatic404.*?true/)
   })
 
+  it('detect page counts correctly for `next build`', async () => {
+    const { stderr } = await nextBuild(appDir, [], {
+      stderr: true,
+      env: { NEXT_TELEMETRY_DEBUG: 1 },
+    })
+
+    const event1 = /NEXT_BUILD_OPTIMIZED[\s\S]+?{([\s\S]+?)}/.exec(stderr).pop()
+    expect(event1).toMatch(/"staticPropsPageCount": 2/)
+    expect(event1).toMatch(/"serverPropsPageCount": 1/)
+    expect(event1).toMatch(/"ssrPageCount": 1/)
+    expect(event1).toMatch(/"staticPageCount": 2/)
+    expect(event1).toMatch(/"totalPageCount": 6/)
+  })
+
   it('detects isSrcDir dir correctly for `next dev`', async () => {
     let port = await findPort()
     let stderr = ''