fix: Add NODE_OPTIONS for debugging in next-dev

vercel · May 8, 2023 · bcc45ec · bcc45ec
1 parent 7e02f11
commit bcc45ec
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/packages/next/src/server/lib/server-ipc/index.ts b/packages/next/src/server/lib/server-ipc/index.ts
@@ -4,6 +4,7 @@ import { genExecArgv, getNodeOptionsWithoutInspect } from '../utils'
 import { deserializeErr, errorToJSON } from '../../render'
 import crypto from 'crypto'
 import isError from '../../../lib/is-error'
+import { genRenderExecArgv } from '../worker-utils'
 
 // we can't use process.send as jest-worker relies on
 // it already and can cause unexpected message errors
@@ -115,10 +116,13 @@ export const createWorker = (
             }
           : {}),
       },
-      execArgv: genExecArgv(
-        isNodeDebugging === undefined ? false : isNodeDebugging,
-        (serverPort || 0) + 1
-      ),
+      execArgv:
+        isNodeDebugging !== undefined
+          ? genExecArgv(
+              isNodeDebugging === undefined ? false : isNodeDebugging,
+              (serverPort || 0) + 1
+            )
+          : genRenderExecArgv(),
     },
     exposedMethods: [
       'initialize',

diff --git a/packages/next/src/server/lib/start-server.ts b/packages/next/src/server/lib/start-server.ts
@@ -1,7 +1,6 @@
 import http from 'http'
 import { isIPv6 } from 'net'
 import * as Log from '../../build/output/log'
-import { getNodeOptionsWithoutInspect } from './utils'
 import type { IncomingMessage, ServerResponse } from 'http'
 import type { ChildProcess } from 'child_process'
 import { normalizeRepeatedSlashes } from '../../shared/lib/utils'
@@ -189,9 +188,10 @@ export async function startServer({
             ...((initialEnv || process.env) as typeof process.env),
             // we don't pass down NODE_OPTIONS as it can
             // extra memory usage
-            NODE_OPTIONS: getNodeOptionsWithoutInspect()
-              .replace(/--max-old-space-size=[\d]{1,}/, '')
-              .trim(),
+            // We should allow this to be passed down for render-server
+            // NODE_OPTIONS: getNodeOptionsWithoutInspect()
+            //   .replace(/--max-old-space-size=[\d]{1,}/, '')
+            //   .trim(),
           },
         },
         exposedMethods: ['initialize'],