[ESLint Plugin] Updates no-document-import-in-page rule to use `pat…

…h` separators (#28768) Context: https://github.com/vercel/next.js/pull/28745/files#r701418932
vercel · Sep 3, 2021 · d056312 · d056312
1 parent 1d08172
commit d056312
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/eslint-plugin-next/lib/rules/no-document-import-in-page.js b/packages/eslint-plugin-next/lib/rules/no-document-import-in-page.js
@@ -1,3 +1,5 @@
+const path = require('path')
+
 module.exports = {
   meta: {
     docs: {
@@ -18,8 +20,8 @@ module.exports = {
 
         if (
           !page ||
-          page.startsWith('/_document') ||
-          page.startsWith('\\_document')
+          page.startsWith(`${path.sep}_document`) ||
+          page.startsWith(`${path.posix.sep}_document`)
         ) {
           return
         }

diff --git a/test/unit/eslint-plugin-next/no-document-import-in-page.test.ts b/test/unit/eslint-plugin-next/no-document-import-in-page.test.ts
@@ -1,3 +1,5 @@
+import path from 'path'
+
 import rule from '@next/eslint-plugin-next/lib/rules/no-document-import-in-page'
 import { RuleTester } from 'eslint'
 ;(RuleTester as any).setDefaultConfig({
@@ -40,7 +42,7 @@ ruleTester.run('no-document-import-in-page', rule, {
       }
     }
     `,
-      filename: 'pages\\_document.js',
+      filename: `pages${path.sep}_document.js`,
     },
     {
       code: `import NextDocument from "next/document"
@@ -54,7 +56,7 @@ ruleTester.run('no-document-import-in-page', rule, {
       }
     }
     `,
-      filename: 'pages/_document.tsx',
+      filename: `pages${path.posix.sep}_document.tsx`,
     },
     {
       code: `import Document from "next/document"
@@ -147,7 +149,7 @@ ruleTester.run('no-document-import-in-page', rule, {
 
       export const Test = () => <p>Test</p>
       `,
-      filename: 'pages\\test.js',
+      filename: `pages${path.sep}test.js`,
       errors: [
         {
           message: