Add warning for Yarn PnP v3 with Node.js < 16.14 (#34818)

* Add warning for Yarn PnP v3 with Node.js < 16.14 * Apply suggestions from code review Co-authored-by: Steven <steven@ceriously.com> * Apply suggestions from code review Co-authored-by: Steven <steven@ceriously.com> * lint-fix Co-authored-by: Steven <steven@ceriously.com>
vercel · Feb 25, 2022 · d09fb1d · d09fb1d
1 parent 35a1af4
commit d09fb1d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/packages/next/bin/next.ts b/packages/next/bin/next.ts
@@ -105,6 +105,22 @@ if (process.env.NODE_ENV) {
 
 ;(process.env as any).NODE_ENV = process.env.NODE_ENV || defaultEnv
 
+// x-ref: https://github.com/vercel/next.js/pull/34688#issuecomment-1047994505
+if (process.versions.pnp === '3') {
+  const nodeVersionParts = process.versions.node
+    .split('.')
+    .map((v) => Number(v))
+
+  if (
+    nodeVersionParts[0] < 16 ||
+    (nodeVersionParts[0] === 16 && nodeVersionParts[1] < 14)
+  ) {
+    log.warn(
+      'Node.js 16.14+ is required for Yarn PnP 3.20+. More info: https://github.com/vercel/next.js/pull/34688#issuecomment-1047994505'
+    )
+  }
+}
+
 // Make sure commands gracefully respect termination signals (e.g. from Docker)
 process.on('SIGTERM', () => process.exit(0))
 process.on('SIGINT', () => process.exit(0))

diff --git a/test/e2e/yarn-pnp/test/utils.ts b/test/e2e/yarn-pnp/test/utils.ts
@@ -41,6 +41,12 @@ export function runTests(example = '') {
   })
   afterAll(() => next?.destroy())
 
+  it('should warn on not fully supported node versions', async () => {
+    expect(next.cliOutput).toContain(
+      'Node.js 16.14+ is required for Yarn PnP 3.20+. More info'
+    )
+  })
+
   it(`should compile and serve the index page correctly ${example}`, async () => {
     const res = await fetchViaHTTP(next.url, '/')
     expect(res.status).toBe(200)