Skip to content

Commit

Permalink
fix: use resolve as a normal module
Browse files Browse the repository at this point in the history
  • Loading branch information
merceyz committed Nov 25, 2020
1 parent 22d414e commit def3d74
Show file tree
Hide file tree
Showing 14 changed files with 18 additions and 30 deletions.
2 changes: 1 addition & 1 deletion packages/next/build/plugins/collect-plugins.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import findUp from 'next/dist/compiled/find-up'
import { promises } from 'fs'
import path from 'path'
import resolve from 'next/dist/compiled/resolve/index.js'
import resolve from 'resolve'
import { execOnce } from '../../next-server/lib/utils'

const { version } = require('next/package.json')
Expand Down
2 changes: 1 addition & 1 deletion packages/next/compiled/debug/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/next/compiled/find-cache-dir/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/next/compiled/http-proxy/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/next/compiled/ora/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/next/compiled/postcss-flexbugs-fixes/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/next/compiled/postcss-loader/cjs.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/next/compiled/postcss-preset-env/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/next/compiled/postcss-scss/scss-syntax.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/next/compiled/strip-ansi/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/next/compiled/terser-webpack-plugin/cjs.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/next/compiled/terser/bundle.min.js

Large diffs are not rendered by default.

20 changes: 6 additions & 14 deletions packages/next/lib/resolve-request.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,10 @@
import resolve from 'next/dist/compiled/resolve/index.js'
import resolve from 'resolve'
import path from 'path'

export function resolveRequest(req: string, issuer: string): string {
// The `resolve` package is prebuilt through ncc, which prevents
// PnP from being able to inject itself into it. To circumvent
// this, we simply use PnP directly when available.
if (process.versions.pnp) {
const { resolveRequest: pnpResolveRequest } = require(`pnpapi`)
return pnpResolveRequest(req, issuer, { considerBuiltins: false })
} else {
const basedir =
issuer.endsWith(path.posix.sep) || issuer.endsWith(path.win32.sep)
? issuer
: path.dirname(issuer)
return resolve.sync(req, { basedir })
}
const basedir =
issuer.endsWith(path.posix.sep) || issuer.endsWith(path.win32.sep)
? issuer
: path.dirname(issuer)
return resolve.sync(req, { basedir })
}
4 changes: 0 additions & 4 deletions packages/next/types/misc.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,6 @@ declare module 'next/dist/compiled/recast' {
import m from 'recast'
export = m
}
declare module 'next/dist/compiled/resolve/index.js' {
import m from 'resolve'
export = m
}
declare module 'next/dist/compiled/send' {
import m from 'send'
export = m
Expand Down

0 comments on commit def3d74

Please sign in to comment.