Skip to content

Commit

Permalink
Update test failure logging (#39655)
Browse files Browse the repository at this point in the history
This attempts to address the missing log outputs noticed in the below test run.
x-ref: https://github.com/vercel/next.js/runs/7839842437?check_suite_focus=true
  • Loading branch information
ijjk committed Aug 16, 2022
1 parent 5061167 commit f00aef4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions run-tests.js
Expand Up @@ -273,7 +273,7 @@ async function main() {
}
)
const handleOutput = (type) => (chunk) => {
if (hideOutput) {
if (hideOutput && !isFinalRun) {
outputChunks.push({ type, chunk })
} else {
process.stderr.write(chunk)
Expand All @@ -287,7 +287,7 @@ async function main() {
child.on('exit', async (code, signal) => {
children.delete(child)
if (code !== 0 || signal !== null) {
if (isFinalRun && hideOutput) {
if (hideOutput) {
// limit out to last 64kb so that we don't
// run out of log room in CI
outputChunks.forEach(({ type, chunk }) => {
Expand Down

0 comments on commit f00aef4

Please sign in to comment.