Skip to content

Commit

Permalink
Avoid skipping the required Test Codemods job (#49589)
Browse files Browse the repository at this point in the history
A required CI check can't be skipped. Otherwise this leads to kodiak
stalling forever on these PRs:

<img width="515" alt="image"
src="https://github.com/vercel/next.js/assets/1365881/142f0f77-1fe1-445c-bdff-1cf7957ebe3e">
  • Loading branch information
sokra committed May 10, 2023
1 parent ba4c2f2 commit f55359f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/build_test_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,6 @@ jobs:
name: Test Codemods
runs-on: ubuntu-latest
needs: [build]
if: ${{ needs.build.outputs.codemodChange == 'yup' }}
timeout-minutes: 5
env:
NEXT_TELEMETRY_DISABLED: 1
Expand All @@ -683,16 +682,19 @@ jobs:

# https://github.com/actions/virtual-environments/issues/1187
- name: tune linux network
if: ${{ needs.build.outputs.codemodChange == 'yup' }}
run: sudo ethtool -K eth0 tx off rx off

- uses: actions/cache@v3
if: ${{ needs.build.outputs.codemodChange == 'yup' }}
timeout-minutes: 5
id: restore-build
with:
path: ./*
key: ${{ github.sha }}-${{ github.run_number }}

- name: Run tests
if: ${{ needs.build.outputs.codemodChange == 'yup' }}
run: docker run --rm -v $(pwd):/work mcr.microsoft.com/playwright:v1.28.1-jammy /bin/bash -c "cd /work && NODE_VERSION=${{ env.NODE_LTS_VERSION }} ./scripts/setup-node.sh && npm i -g pnpm@${PNPM_VERSION} > /dev/null && cd ./packages/next-codemod && pnpm build && pnpm test >> /proc/1/fd/1"

testIntegration:
Expand Down

0 comments on commit f55359f

Please sign in to comment.