Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
next/script: simplify logic and update tests (#40026)
The PR is the first step toward fixing #40025. The PR makes the `script-loader` integration test run on both dev and production modes. Some existing test cases are skipped in dev mode because corresponding features are not strict mode resilient and thus will fail. They will be included in dev mode tests in the future. The PR also merges some duplicated logic in `next/script`, and adds a detailed comment about how `onReady` works. In the next PR, I will try to fix `onLoad` being called more than once under strict mode. Co-authored-by: Houssein Djirdeh <houssein.djirdeh@gmail.com>
- Loading branch information
1 parent
885defd
commit f9706e0
Showing
5 changed files
with
205 additions
and
196 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 0 additions & 31 deletions
31
test/integration/script-loader/strictmode/pages/onready.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.