Fix bug in catch-all routes with SSG #10379

TheDSCPL · 2020-02-02T00:48:35Z

The catch-all routes in SSG wasn't working because it was escaping the '/' characters used to join the parameters instead of joining the parameters escaped individually.

TheDSCPL · 2020-02-02T00:50:50Z

Hey @Timer

From the [https://github.com/zeit/next.js/blame/db90ffe1ea7fe4c3dde86fce8e45470c803a7063/packages/next/build/utils.ts#L595](the git blame) I can see it was you who wrote this so you're probably more familiar with the code :)

ijjk · 2020-02-02T00:55:20Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	TheDSCPL/next.js canary	Change
buildDuration	13.6s	13.6s	⚠️ +4ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.module.js gzip	4.11 kB	4.11 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	TheDSCPL/next.js canary	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.08 kB	3.08 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	TheDSCPL/next.js canary	Change
buildDuration	14s	14.6s	⚠️ +650ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.module.js gzip	4.11 kB	4.11 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_error.js gzip	46.7 kB	46.7 kB	✓
404.html gzip	1.43 kB	1.43 kB	✓
hooks.html gzip	1.07 kB	1.07 kB	✓
index.js gzip	46.8 kB	46.8 kB	✓
link.js gzip	72.3 kB	72.3 kB	✓
routerDirect.js gzip	70.6 kB	70.6 kB	✓
withRouter.js gzip	70.4 kB	70.4 kB	✓
Overall change	309 kB	309 kB	✓

Commit: 188dcf3

TheDSCPL · 2020-02-02T01:59:28Z

Some tests are failing because expectedManifestRoutes is returning an incorrect result, I believe.

For example, the parameters ["foo","bar"] would be translating into the URL foo%2Fbar instead of the expected foo/bar.

These tests are supposed to fail because the routes manifest file of the snapshot used in the tests is wrong

ijjk

Hi, this looks correct to me. Can we update the expectedManifestRoutes test to not have the encoded /

-   "/catchall/another%2Fvalue": Object {
-     "dataRoute": "/_next/data/D_tGOM2RU1gb-ZdBcwOUJ/catchall/another%2Fvalue.json",
+   "/catchall/another/value": Object {
+     "dataRoute": "/_next/data/D_tGOM2RU1gb-ZdBcwOUJ/catchall/another/value.json",

ijjk · 2020-02-02T21:47:39Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	TheDSCPL/next.js canary	Change
buildDuration	12.1s	12.1s	-18ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.module.js gzip	4.11 kB	4.11 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	TheDSCPL/next.js canary	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	TheDSCPL/next.js canary	Change
buildDuration	12s	11.9s	-148ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.module.js gzip	4.11 kB	4.11 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_error.js gzip	46.7 kB	46.7 kB	✓
404.html gzip	1.43 kB	1.43 kB	✓
hooks.html gzip	1.06 kB	1.06 kB	✓
index.js gzip	46.8 kB	46.8 kB	✓
link.js gzip	72.3 kB	72.3 kB	✓
routerDirect.js gzip	70.6 kB	70.6 kB	✓
withRouter.js gzip	70.4 kB	70.4 kB	✓
Overall change	309 kB	309 kB	✓

Commit: c7dab83

fixed

ijjk · 2020-02-03T03:01:47Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	TheDSCPL/next.js canary	Change
buildDuration	11.5s	11.9s	⚠️ +402ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.module.js gzip	4.11 kB	4.11 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	TheDSCPL/next.js canary	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.02 kB	1.02 kB	✓
Overall change	3.07 kB	3.07 kB	✓

Serverless Mode

General Overall increase ⚠️

	zeit/next.js canary	TheDSCPL/next.js canary	Change
buildDuration	12.5s	12.1s	-391ms
nodeModulesSize	52.1 MB	52.1 MB	⚠️ +10 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..d6ae.js gzip	16.2 kB	16.2 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	69.9 kB	69.9 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
main-HASH.module.js gzip	4.11 kB	4.11 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	15.1 kB	15.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	64.6 kB	64.6 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	TheDSCPL/next.js canary	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.js gzip	1.15 kB	1.15 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.89 kB	2.89 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.68 kB	9.68 kB	✓

Client Pages Modern

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_app.module.js gzip	576 B	576 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.46 kB	2.46 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.22 kB	7.22 kB	✓

Client Build Manifests

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	TheDSCPL/next.js canary	Change
_error.js gzip	46.7 kB	46.7 kB	✓
404.html gzip	1.43 kB	1.43 kB	✓
hooks.html gzip	1.06 kB	1.06 kB	✓
index.js gzip	46.8 kB	46.8 kB	✓
link.js gzip	72.3 kB	72.3 kB	✓
routerDirect.js gzip	70.6 kB	70.6 kB	✓
withRouter.js gzip	70.4 kB	70.4 kB	✓
Overall change	309 kB	309 kB	✓

Commit: 50f30ef

* Fix bug in catch-all routes with SSG * fix slash Co-authored-by: Joe Haddad <timer150@gmail.com>

Fix bug in catch-all routes with SSG

188dcf3

TheDSCPL requested review from ijjk, lfades, Timer and timneutkens as code owners February 2, 2020 00:48

ijjk previously requested changes Feb 2, 2020

View reviewed changes

Merge branch 'canary' into canary

c7dab83

fix slash

50f30ef

Timer added this to the 9.2.2 milestone Feb 3, 2020

Timer added the ready to land label Feb 3, 2020

Timer approved these changes Feb 3, 2020

View reviewed changes

Timer merged commit a433b9b into vercel:canary Feb 3, 2020

Timer mentioned this pull request Feb 3, 2020

Build directory output for catch-all routes #10190

Closed

jamespohalloran mentioned this pull request Feb 3, 2020

static generation for docs tinacms/tina.io#14

Merged

chibicode pushed a commit to chibicode/next.js that referenced this pull request Feb 11, 2020

Fix bug in catch-all routes with SSG (vercel#10379)

3bda7b8

* Fix bug in catch-all routes with SSG * fix slash Co-authored-by: Joe Haddad <timer150@gmail.com>

ijjk mentioned this pull request Feb 25, 2020

getStaticPaths builds the wrong data files with [...params] #10689

Closed

This was referenced Mar 13, 2020

[Snyk] Upgrade next from 9.2.1 to 9.2.2 pixeldrew/hero-masq#10

Closed

[Snyk] Upgrade @next/mdx from 9.0.5 to 9.2.2 shahinalzahrani/docs#1

Open

This was referenced Mar 22, 2020

[Snyk] Upgrade next from 9.1.5 to 9.2.2 evantahler/next-static-hosting#3

Merged

[Snyk] Upgrade next from 9.2.1 to 9.2.2 grouparoo/next-plugins-example#3

Merged

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix bug in catch-all routes with SSG #10379

Fix bug in catch-all routes with SSG #10379

TheDSCPL commented Feb 2, 2020

TheDSCPL commented Feb 2, 2020

ijjk commented Feb 2, 2020

TheDSCPL commented Feb 2, 2020 •

edited

ijjk left a comment

ijjk commented Feb 2, 2020

ijjk commented Feb 3, 2020

Fix bug in catch-all routes with SSG #10379

Fix bug in catch-all routes with SSG #10379

Conversation

TheDSCPL commented Feb 2, 2020

TheDSCPL commented Feb 2, 2020

ijjk commented Feb 2, 2020

Stats from current PR

TheDSCPL commented Feb 2, 2020 • edited

ijjk left a comment

Choose a reason for hiding this comment

ijjk commented Feb 2, 2020

Stats from current PR

ijjk commented Feb 3, 2020

Stats from current PR

TheDSCPL commented Feb 2, 2020 •

edited