Add support for SCSS options #11063

ijjk · 2020-03-13T22:06:53Z

As discussed this adds support for the SASS options object

ijjk · 2020-03-13T22:12:32Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
buildDuration	9.5s	9.7s	⚠️ +156ms
nodeModulesSize	56.6 MB	56.6 MB	⚠️ +547 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
main-HASH.js gzip	5.77 kB	5.77 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..8eb0.js gzip	9.78 kB	9.78 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.4 kB	55.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
_app.js gzip	1.09 kB	1.09 kB	✓
_error.js gzip	2.96 kB	2.96 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.06 kB	2.06 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
index.html gzip	916 B	916 B	✓
link.html gzip	925 B	925 B	✓
withRouter.html gzip	913 B	913 B	✓
Overall change	2.75 kB	2.75 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
buildDuration	10.6s	10.3s	-322ms
nodeModulesSize	56.6 MB	56.6 MB	⚠️ +547 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
main-HASH.js gzip	5.77 kB	5.77 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
de003c3a9d30..8eb0.js gzip	9.78 kB	9.78 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	55.4 kB	55.4 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
main-HASH.module.js gzip	4.78 kB	4.78 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..dule.js gzip	6.71 kB	6.71 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	51.4 kB	51.4 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
polyfills-HASH.js gzip	26.2 kB	26.2 kB	✓
Overall change	26.2 kB	26.2 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
_app.js gzip	1.09 kB	1.09 kB	✓
_error.js gzip	2.96 kB	2.96 kB	✓
hooks.js gzip	664 B	664 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	1.89 kB	1.89 kB	✓
routerDirect.js gzip	279 B	279 B	✓
withRouter.js gzip	278 B	278 B	✓
Overall change	7.38 kB	7.38 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
_app.module.js gzip	594 B	594 B	✓
_error.module.js gzip	2.06 kB	2.06 kB	✓
hooks.module.js gzip	370 B	370 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	1.48 kB	1.48 kB	✓
routerDirect..dule.js gzip	271 B	271 B	✓
withRouter.m..dule.js gzip	270 B	270 B	✓
Overall change	5.26 kB	5.26 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js add/NEXT-121	Change
_error.js gzip	294 kB	293 kB	-426 B
404.html gzip	1.32 kB	1.32 kB	✓
hooks.html gzip	957 B	957 B	✓
index.js gzip	294 kB	293 kB	-792 B
link.js gzip	301 kB	301 kB	-104 B
routerDirect.js gzip	300 kB	300 kB	⚠️ +156 B
withRouter.js gzip	300 kB	300 kB	⚠️ +53 B
Overall change	1.49 MB	1.49 MB	-1.11 kB

packages/next/build/webpack-config.ts

timneutkens · 2020-03-16T09:03:59Z

I've updated the PR 👍

* Add support for SCSS includePaths * Support sassOptions instead of just includePaths Co-authored-by: Tim Neutkens <timneutkens@me.com> Co-authored-by: Joe Haddad <joe.haddad@zeit.co>

ijjk added 2 commits March 13, 2020 17:05

Add support for SCSS includePaths

6414d0a

Merge remote-tracking branch 'upstream/canary' into add/NEXT-121

b08862a

ijjk added this to the 9.3.1 milestone Mar 13, 2020

ijjk requested review from lfades, Timer and timneutkens as code owners March 13, 2020 22:06

timneutkens reviewed Mar 14, 2020

View reviewed changes

packages/next/build/webpack-config.ts Outdated Show resolved Hide resolved

timneutkens changed the title ~~Add support for SCSS includePaths~~ Add support for SCSS options Mar 14, 2020

timneutkens mentioned this pull request Mar 14, 2020

Unable to find sass-loader in next.config.js #11048

Closed

Support sassOptions instead of just includePaths

c31249a

timneutkens approved these changes Mar 16, 2020

View reviewed changes

timneutkens added the ready to land label Mar 16, 2020

Timer added 6 commits March 16, 2020 05:05

Merge branch 'canary' into add/NEXT-121

3a9ea12

Merge branch 'canary' into add/NEXT-121

1ae4c20

Merge branch 'canary' into add/NEXT-121

558f553

Merge branch 'canary' into add/NEXT-121

7b09465

Merge branch 'canary' into add/NEXT-121

ef23b33

Merge branch 'canary' into add/NEXT-121

6b8816b

timneutkens merged commit ea7c1e1 into vercel:canary Mar 16, 2020

timneutkens deleted the add/NEXT-121 branch March 16, 2020 09:55

yomed mentioned this pull request Mar 18, 2020

Built-in Sass Support for Global Stylesheets (Variables/Mixins.scss) #10912

Closed

This was referenced Apr 2, 2020

Sass @use statements don't work #11610

Closed

Demo Sass capabilities in with-next-sass example #11674

Closed

fix: find workaround for Sass imports tutorbookapp/tutorbook#7

Closed

snyk-bot mentioned this pull request Apr 9, 2020

[Snyk] Upgrade next from 9.1.1 to 9.3.1 cds-snc/a11y-reporting#6

Open

Tylerian mentioned this pull request Apr 28, 2020

Global Sass imports don't work when you use variables, mixins, functions, etc! #11617

Closed

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for SCSS options #11063

Add support for SCSS options #11063

ijjk commented Mar 13, 2020 •

edited by timneutkens

ijjk commented Mar 13, 2020

timneutkens commented Mar 16, 2020

Add support for SCSS options #11063

Add support for SCSS options #11063

Conversation

ijjk commented Mar 13, 2020 • edited by timneutkens

ijjk commented Mar 13, 2020

Stats from current PR

timneutkens commented Mar 16, 2020

ijjk commented Mar 13, 2020 •

edited by timneutkens