Demo Sass capabilities in with-next-sass example
#11674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Apr 5, 2020
| @@ -1,5 +1,8 @@ | |||
| @use '@material/typography'; | |||
There was a problem hiding this comment.
The includePaths option is not needed if you prefix it with ~ right 🤔
Suggested change
| @use '@material/typography'; | |
| @use '~@material/typography'; |
That opts in the file for module resolution through webpack
There was a problem hiding this comment.
Nope, because the Sass modules that I'm using have their own imports (that do not use the ~ in their @use statements).
I don't want to mess with my dependencies's source code.
There was a problem hiding this comment.
Seems like those modules are not working in the general ecosystem overall then?
|
Closing due to inactivity. Feel free to reopen with an updated example / feedback above addressed. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #11610 by demoing the recently implemented fix in the official
with-next-sassexample.I've used Google's MDC
@material/typographypackage to demonstrate some common Sass functionality:@useand@includestatements for scoped SCSS modules@usefor including global Sass stylingI'd also strongly suggest updating your website's Sass documentation with a link to this example. And make it clear what the best way to use Sass is (i.e. using
@zeit/next-sassor the out-of-box stuff) as described in this issue.